virtualbox-ose-kmod rc scripts

[Dag-Erling Smørgrav]

Bernhard Fröhlich <decke at bluelife.at> writes:
> The vboxdrv module needs to be loaded via loader.conf or it can cause
> kernel panics.

Hmm, details?  I might look into it (although I won't really have time
until late June).

I loaded it manually after installation and have three VMs running now,
one of which completed a buildworld buildkernel -j3 last night.

But loading it in the rc script doesn't really hurt if it's already
in loader.conf.

As for the issue of redundant code in the vboxnet rc script:

--- a/usr/local/etc/rc.d/vboxnet	2014-05-25 05:26:59.000000000 +0200
+++ b/usr/local/etc/rc.d/vboxnet	2014-05-26 09:45:16.002955115 +0200
@@ -24,47 +24,18 @@
 
 vboxnet_start()
 {
-	if ! kldstat -q -m ng_vboxnetflt;
-	then
-		if ! kldload vboxnetflt > /dev/null 2>&1;
-		then
-			warn "Can't load vboxnetflt module."
-			return 1
-		fi
-	fi
-
-	if ! kldstat -q -m vboxnetadp;
-	then
-		if ! kldload vboxnetadp > /dev/null 2>&1;
-		then
-			warn "Can't load vboxnetadp module."
-			return 1
-		fi
-	fi
-
+	load_kld -m ng_vboxnetflt vboxnetflt
+	load_kld vboxnetadp
 	# initialize configured host-only interfaces
 	/usr/local/bin/VBoxManage list hostonlyifs >/dev/null
 }
 
 vboxnet_stop()
 {
-	if kldstat -q -m vboxnetadp;
-	then
-		if ! kldunload vboxnetadp > /dev/null 2>&1;
-		then
-			warn "Can't unload vboxnetadp module."
-			return 1
-		fi
-	fi
-
-	if kldstat -q -m ng_vboxnetflt;
-	then
-		if ! kldunload vboxnetflt > /dev/null 2>&1;
-		then
-			warn "Can't unload vboxnetflt module."
-			return 1
-		fi
-	fi
+	kldunload vboxnetadp >/dev/null 2>&1 ||
+		warn "Can't unload vboxnetadp module."
+	kldunload vboxnetflt >/dev/null 2>&1 ||
+		warn "Can't unload vboxnetflt module."
 }
 
 load_rc_config $name

DES
-- 
Dag-Erling Smørgrav - des at des.no