VBox upgrade fails

[Bernhard Froehlich]

On 20.04.2012 02:10, Petro Rossini wrote:
> On Thu, Apr 19, 2012 at 5:33 PM, AN <andy at neu.net> wrote:
>> On Thu, 19 Apr 2012, Petro Rossini wrote:
>>> On Thu, Apr 19, 2012 at 6:02 AM, AN <andy at neu.net> wrote:
>>>> # portupgrade -va
>>>> --->  Session started at: Wed, 18 Apr 2012 15:56:15 -0400
>>>> --->  Upgrade of emulators/virtualbox-ose-kmod started at: Wed, 18 
>>>> Apr
>>>> --->  Upgrading 'virtualbox-ose-kmod-4.1.8_1' to
>>>> 'virtualbox-ose-kmod-4.1.12' (emulators/virtualbox-ose-kmod)
>>>> --->  Build of emulators/virtualbox-ose-kmod started at: Wed, 18 
>>>> Apr 2012
>>>> --->  Building '/usr/ports/emulators/virtualbox-ose-kmod'
>>>> ===>  Cleaning for virtualbox-ose-kmod-4.1.12
>>>> cd
>>>>
>>>> 
>>>> /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-4.1.12/out/freebsd.amd64/release/bin/src
>>>> && make SYSDIR=/usr/src/sys
>>>> *** Building 'vboxdrv' module ***
>>>> "/usr/share/mk/bsd.own.mk", line 483: MK_CLANG_IS_CC can't be set 
>>>> by a
>>>> user.
>>>> *** [all] Error code 1
>>>>
>>>> I think it is a problem with the file /usr/share/mk/bsd.own.mk.  I 
>>>> will
>>>> send a message to the ports list.
>>>
>>> According to
>>> http://www.freebsd.org/cgi/cvsweb.cgi/src/share/mk/bsd.own.mk,
>>> Revision 1.107.2.5,
>>>
>>> this parameter decides whether the CLANG compiler is installed as
>>> /usr/bin/cc.
>>>
>>> VirtualBox does not install the cc (that's done by installworld of 
>>> the
>>> base system build) so to set the variable here does not make sense 
>>> to
>>> me.
>>
>> The following fix was provided by someone on the ports list.
>>
>> cd /usr/ports/emulators/virtualbox-ose-kmod/files &&
>> rm patch-src_VBox_HostDrivers_Support_freebsd_Makefile
>> patch-src_VBox_HostDrivers_VBoxNetAdp_freebsd_Makefile
>> patch-src_VBox_HostDrivers_VBoxNetFlt_freebsd_Makefile
>> and start the update again
>>
>> VBox upgrade completed successfully.
>
> I am guessing why it was there in the first place:
>
> To test whether the cc is CLANG?
>
> Does VirtualBox compile work on a CLANG compiled system?

No VirtualBox cannot be compiled with CLANG because it doesn't support
global register variables. So you get:

src/recompiler/target-i386/exec.h:41:30: error: global register 
variables are not supported
register struct CPUX86State *env asm(AREG0);


The patches were made by sobomax to fix that problem on RELENG_9:

kBuild: Installing 
/usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-4.1.12/out/freebsd.amd64/release/bin/src/vboxnetflt/Makefile
cd 
/usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-4.1.12/out/freebsd.amd64/release/bin/src 
&& make SYSDIR=/usr/src/sys
*** Building 'vboxdrv' module ***
"/usr/src/sys/conf/kmod.mk", line 116: Malformed conditional 
(${MK_CLANG_IS_CC} == "no" && ${CC:T:Mclang} != "clang")
"/usr/src/sys/conf/kmod.mk", line 120: if-less endif
"/usr/src/sys/conf/kern.mk", line 18: Malformed conditional 
(${MK_CLANG_IS_CC} != "no" || ${CC:T:Mclang} == "clang")
"/usr/src/sys/conf/kern.mk", line 31: if-less endif
"/usr/src/sys/conf/kern.mk", line 101: Malformed conditional 
(${MK_CLANG_IS_CC} != "no" || ${CC:T:Mclang} == "clang")
"/usr/src/sys/conf/kern.mk", line 107: if-less endif
make: fatal errors encountered -- cannot continue
*** Error code 1


As it seems those patches cause more problems than they solve so I'm 
going to remove them.

-- 
Bernhard Froehlich
http://www.bluelife.at/