VirtualBox + VIMAGE

[Bernhard Froehlich]

On Wed, 26 Jan 2011 18:23:26 -0600, Brandon Gooch wrote:
> On Jan 26, 2011, at 5:33 PM, Bernhard Froehlich <decke at FreeBSD.org> wrote:
> 
>> On Wed, 26 Jan 2011 23:27:27 +0200, Mikolaj Golub wrote:
>>> On Wed, 26 Jan 2011 14:18:03 +0000 (UTC) Bjoern A. Zeeb wrote:
>>>
>>> BAZ> On Wed, 26 Jan 2011, Mikolaj Golub wrote:
>>>
>>>>>
>>>>> On Wed, 26 Jan 2011 09:15:46 +0000 (UTC) Bjoern A. Zeeb wrote:
>>>>>
>>>>> BAZ> I think you should wrap the CURVNET changes in __FreeBSD_version
>>>>> BAZ> checks so that the port, should it run elsewhere or on older
>>> FreeBSDs
>>>>> BAZ> (if it runs there) not trouble people having to patch it away.
>>>>>
>>>>> BAZ> #if defined(__FreeBSD_version) && __FreeBSD_version >= 800500
>>>>> BAZ> #endif
>>>>>
>>>>> BAZ> might be a save bet.
>>>>>
>>>>> Thanks. Something like in the patch below?
>>>>>
>>>>> Note, I have not run this version yet. Will test it tonight or tomorrow.
>>>
>>> BAZ> Well, you will need to include <sys/param.h> as well, and that only if
>>> BAZ> you are on FreeBSD so you'll need an extra check for just that I
>>> BAZ> guess.  Not sure how vbox handles the all this in their guts.
>>>
>>> The file has already had '#include <sys/param.h>' among other includes. It
>>> just is not seen in the patch. The file is used only for FreeBSD driver so
>>> there is no need in extra check I think.
>>>
>>> I have tested this latest version of the patch. It works for me.
>>
>> Could someone with a vimage enabled kernel please test bridging with a
>> stock emulators/virtualbox-ose-kmod port? There was a report that this
>> causes a crash and it would be good to verify if that is still valid:
>>
>> http://lists.freebsd.org/pipermail/freebsd-emulation/2009-November/007055.html
>>
>> --
>> Bernhard Froehlich
>> http://www.bluelife.at/
>> _______________________________________________
>> freebsd-emulation at freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/freebsd-emulation
>> To unsubscribe, send any mail to "freebsd-emulation-unsubscribe at freebsd.org"
> 
> It still crashes.
> 
> -Brandon

Thanks for testing that. Does vbox crash or the kernel? Is it possible
to get a backtrace?

We could try to detect if the kernel has vimage enabled (sysctl?) and
also enable the vimage option per default in the port in that case.

-- 
Bernhard Froehlich
http://www.bluelife.at/