[patch] Mk/bsd.linux-rpm.mk: introduce some linux-f8 infrastructure

Alexander Leidinger Alexander at Leidinger.net
Wed Mar 4 00:31:49 PST 2009


Quoting Boris Samorodov <bsam at ipt.ru> (from Tue, 03 Mar 2009 18:55:01 +0300):

> I'm going to commit an attached patch. This patch is a noop for
> current ports structure (no need to ask an approval from portmgr)
> but is needed for new linux-f8 ports.

While I agree with you... does portmgr agree with you too? Sometimes  
they have different opinions than committers about what should be  
tested in an exp-build.

> There are two points (both taken from emulators/linux_base-f8):
> . define LINUX_OSRELEASE variable (linux-f8 packages should be
>   build with compat.linux.osrelease=2.6.16);

Why do you use ECHO_CMD? Is there some whitespace which needs to be deleted?

> . define MASTER_SITE_SUBDIR and MASTER_SITE_SRC_SUBDIR when
>   LINUX_DIST_VER=8 (no such ports ATM).

Why is there ifndef MASTER_SITES (only in the context of your patch,  
so not really related)? Is there a difference for "?=" between an  
empty MASTER_SITES and an undefined one?

Bye,
Alexander.

-- 
And this is good old Boston,
The home of the bean and the cod,
Where the Lowells talk only to Cabots,
And the Cabots talk only to God.

http://www.Leidinger.net    Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org       netchild @ FreeBSD.org  : PGP ID = 72077137


More information about the freebsd-emulation mailing list