Call for review && test: linux_kdump-1.6

[Chagin Dmitry]

On Sun, 13 Apr 2008, Kostik Belousov wrote:

> On Sun, Apr 13, 2008 at 08:32:48PM +0200, Roman Divacky wrote:
>> On Sun, Apr 13, 2008 at 09:58:08PM +0400, Chagin Dmitry wrote:
>>> On Sat, 12 Apr 2008, Roman Divacky wrote:
>>>
>>>>> And question: whether i can add to linuxolator some ktr_struct
>>>>>    functionality?
>>>>
>>>> sure... please provide a patch and I'll take care about it.
>>>
>>> ok, thnx :)
>>> what about EJUSTRETURN?
>>> i attached simple patch for demo only (not tested).
>>
>> uh... can you provide diff -u ? I dont understand the diff at all ;)
>
> Also, please note that the ML software strips your attachments. Either
> inline the patch, or use the plain-text content-type for it.
>

ups... ah google ))
i have understood, sorry and thnx.
Speech about that in linux_kdump it is impossible to distinguish
EJUSTRETURN from a real error. look:

--- sys/i386/i386/trap.c.orig	2008-04-13 21:39:18.000000000 +0400
+++ sys/i386/i386/trap.c	2008-04-13 22:35:25.000000000 +0400
@@ -1091,8 +1091,12 @@
   	    td->td_proc->p_pid, td->td_name, code);

   #ifdef KTRACE
-	if (KTRPOINT(td, KTR_SYSRET))
-		ktrsysret(code, error, td->td_retval[0]);
+	if (KTRPOINT(td, KTR_SYSRET)) {
+		if (error == EJUSTRETURN)
+			ktrsysret(code, 0, td->td_retval[0]);
+		else
+			ktrsysret(code, error, td->td_retval[0]);
+	}
   #endif

   	/*
@@ -1104,4 +1108,3 @@

   	PTRACESTOP_SC(p, td, S_PT_SCX);
   }
-



-- 
Have fun!
chd