[patch] for bsd.linux-rpm.mk (add auto sources fetching)

Alexander Leidinger Alexander at Leidinger.net
Sat Mar 18 22:32:49 UTC 2006


Am Thu, 16 Mar 2006 23:23:03 +0300
schrieb Boris Samorodov <bsam at ipt.ru>:

> On Thu, 16 Mar 2006 18:16:25 +0100 Alexander Leidinger wrote:
> > Am Thu, 16 Mar 2006 18:25:23 +0300
> > schrieb Boris Samorodov <bsam at ipt.ru>:
> 
> > > +.  if defined(PACKAGE_BUILDING) && ${AUTO_LINUX_SRC} == "yes"
> > > +DISTFILES+=		${DISTNAME}${SRC_SUFX}
> > > +MASTER_SITE_SUBDIR+=	3/SRPMS
> > > +ALWAYS_KEEP_DISTFILES=	yes
> > >  .  endif
> 
> > You are assuming this will only be used for some specific directory
> > layouts without the possibility to override this. I suggest to
> > introduce an overridable variable... maybe MASTER_SITE_SRC_SUBDIR or
> > whatever which will be added to MASTER_SITE_SUBDIR then. 
> 
> > Maybe you can change the patch to have a look at a SRC_DISTFILES
> > variable and add this content to the DISTFILES in the PACKAGE_BUILDING
> > case instead of hardcoding one file.
> 
> Agreed to both. New patch is attached.
> 
> If auto fetching go well, then variable AUTO_LINUX_SRC may be

I don't think we need it, I documented the behavior and what to do in
case of e.g. a commercial RPM.

> deletted. But for now it may be used if something go wrong with auto
> fetching.

Attached is a diff which I intend to commit. It's a combination of your
patches, and some own stuff (start of docs, a new new-plist target and
some mods to your patches). What do you think about it?

Bye,
Alexander.

-- 
              To boldly go where I surely don't belong.
http://www.Leidinger.net                       Alexander @ Leidinger.net
  GPG fingerprint = C518 BC70 E67F 143F BE91  3365 79E2 9C60 B006 3FE7
WL http://www.amazon.de/exec/obidos/registry/1FZ4DTHQE9PQ8/ref=wl_em_to/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bsd.linux-rpm.mk.diff
Type: text/x-patch
Size: 4959 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-emulation/attachments/20060318/fb483175/bsd.linux-rpm.mk.bin


More information about the freebsd-emulation mailing list