qemu hack

[NAKATA Maho]

In Message-ID: <20060119192137.GB13509 at saturn.kn-bremen.de> 
Juergen Lock <nox at jelal.kn-bremen.de> wrote:

> On Wed, Jan 18, 2006 at 09:37:40AM +0900, NAKATA Maho wrote:
> > Dear Juergen and list,
> > I add a hack for qemu port; speed up hack of cirrus vga.
> > http://lists.gnu.org/archive/html/qemu-devel/2006-01/msg00208.html
> > and now qemu seems to be faster a bit.
> > (hope someone can do benchmark)
> > 
> > Juergen, can I commit to port?
> 
> Well you didnt bump PORTREVISION, also you could call patch with --quiet
Right. According to
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html

> PORTREVISION should be increased each time a change is made to the port which significantly affects the content or structure of the derived package.
> Changes to MASTER_SITES or other functional changes to the port which do not affect the resulting package.

My understanding is adding a knob do not affect the resulting packages
since I didn't change anything when installing with `make install' (but
make -DWITH_HACKS install).

I took this way - since adding unofficial patches are considered as
minor project fork and as you found below, there might be a side effects
as well. IMHO any patch should be upstreamed otherwise
we should fork the project. so I merely added as a knob.

> for the patch3_cirrus file.  Other than that its ok with me...
okay.

> I do get redraw artefacts with the patch when I play with the scrollbar
> on the konqueror that comes up right when I boot the kanotix livecd
> iso in qemu tho:
> http://debian.tu-bs.de/kanotix/KANOTIX-2005-04/KANOTIX-2005-04.iso
;) oh 

sincerely yours,
-- NAKATA, Maho (maho at FreeBSD.org)