Updated switch/glue patch?
Stefan Bethke
stb at lassitu.de
Thu Dec 29 00:29:24 UTC 2011
Am 28.12.2011 um 19:34 schrieb Adrian Chadd:
> On 28 December 2011 05:52, Stefan Bethke <stb at lassitu.de> wrote:
>
>> Implement a number of suggestions by Adrian:
>> * add mutex to callout
>> * add locking macros
>> * rename _lockheld to _locked
>> * bring debugging under DEBUG, incl. sysctls
>> * move i2c select retry to its own function
>> * mtx_sleep when retrying the select
>> * only reset bus on probe
>> * do not DELAY on phy access retries
>> * count phy access retries (under DEBUG)
>>
>> http://gitorious.org/~stb/freebsd/stb-adrianchadd-freebsd-work (branch work/ath)
>> http://www.lassitu.de/freebsd/etherswitch-adrian.patch (patch against Adrians gitorious repo as of now)
>> http://www.lassitu.de/freebsd/etherswitch.tbz (all files)
>
> The patch didn't compile - you were missing softc *sc pointers in
> smi_read_locked and smi_write_locked.
I've updated the above with code that compiles as a module and compiled-in, and is working as I expect it to.
> Also, remember to use braces ( ) around fields in a macro. :)
Where specifically did I miss them?
Thanks,
Stefan
--
Stefan Bethke <stb at lassitu.de> Fon +49 151 14070811
More information about the freebsd-embedded
mailing list