Review request: iicbus_transfer_gen() repeated start support

Warner Losh imp at bsdimp.com
Mon Nov 8 16:49:36 UTC 2010


  On 11/07/2010 20:37, Andrew Thompson wrote:
> On 7 June 2010 03:02, Nathan Whitehorn<nwhitehorn at freebsd.org>  wrote:
>> I committed yesterday some changes to the iicbus_transfer() API that allow
>> using that interface to send messages containing repeated starts. The
>> attached patch implements this for the iicbus_transfer_gen() case, but I
>> don't have any I2C controllers that use this routine, so I can't test it. I
>> would much appreciate it if someone could review and test the patch for me.
>> -Nathan
> I have tested this and nothing broke. The i2c devices+drivers on my
> board do not use IIC_M_NOSTART or IIC_M_NOSTOP flags so couldn't
> verify that part of it.
I'll have to try things on my AT91 box too.

Do the upper layers need to warn about IIC_M_NOSTART/IIC_M_NOSTOP flags 
not being supported?  Or have some way for userland to know they can 
issue the ioctl?

Warner


More information about the freebsd-embedded mailing list