[Bug 233843] sysutils/logstash5: logstash-plugin binary is not executable

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233843

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
            Summary|sysutils/logstash5          |sysutils/logstash5:
                   |bin/logstash-plugin not     |logstash-plugin binary is
                   |executable                  |not executable
           Severity|Affects Some People         |Affects Many People
              Flags|                            |merge-quarterly?
           Keywords|                            |needs-patch, needs-qa

--- Comment #1 from Kubilay Kocak <koobs at FreeBSD.org> ---
If a better alternate method within the context of the build system (such as a
bug fix) is not possible/feasable, the workaround the manually modify the
executables permissions should:

- Use the ${CHMOD} variable provided by the framework
- Use ${LOCALBASE} / PREFIX-safe variable for the path
- Happen at post-install: stage (in STAGEDIR}

However, the port already includes the following block in do-install:

  for x in ${LOGSTASH_BIN_FILES}
    @${CHMOD} ${BINMODE} ${STAGEDIR}${LOGSTASH_DIR}/bin/${x}

But LOGSTASH_BIN_FILES only contains 'logstash'

The sysutils/logstash6 port takes a more robust approach, but chmod'ing all
binaries in the path:

  ${CHMOD} ${BINMODE} ${STAGEDIR}${LOGSTASH_DIR}/bin/*

I recommend taking the latter (logstash6) approach in this port.

-- 
You are receiving this mail because:
You are the assignee for the bug.