[Bug 230846] dtrace FBT doesn't know about ifuncs

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Aug 28 20:22:22 UTC 2018


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230846

--- Comment #4 from commit-hook at freebsd.org ---
A commit references this bug:

Author: markj
Date: Tue Aug 28 20:21:38 UTC 2018
New revision: 338359
URL: https://svnweb.freebsd.org/changeset/base/338359

Log:
  Allow multiple FBT probes to share a tracepoint.

  With GNU ifuncs, multiple FBT probes may correspond to the same
  instruction.  fbt_invop() assumed that this could not happen and
  would return after the first probe found in the global FBT hash
  table, which might not be the one that's enabled.  Fix the problem
  on x86 by linking probes that share a tracepoint and having each
  linked probe fire when the tracepoint is hit.

  PR:           230846
  Approved by:  re (gjb)
  Sponsored by: The FreeBSD Foundation
  Differential Revision:        https://reviews.freebsd.org/D16921

Changes:
  head/sys/cddl/dev/fbt/aarch64/fbt_isa.c
  head/sys/cddl/dev/fbt/arm/fbt_isa.c
  head/sys/cddl/dev/fbt/fbt.c
  head/sys/cddl/dev/fbt/fbt.h
  head/sys/cddl/dev/fbt/mips/fbt_isa.c
  head/sys/cddl/dev/fbt/powerpc/fbt_isa.c
  head/sys/cddl/dev/fbt/riscv/fbt_isa.c
  head/sys/cddl/dev/fbt/x86/fbt_isa.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-dtrace mailing list