Patch for the trap handler and some test list sanity

Mark Johnston markj at freebsd.org
Fri Jun 21 19:02:01 UTC 2013


On Sat, Jun 22, 2013 at 3:00 AM, Mark Johnston <markj at freebsd.org> wrote:
> On Fri, Jun 21, 2013 at 11:47:43AM -0700, Jeff Ford wrote:
>> Anton Rang and I did some DTrace work for Isilon that we're trying to get
>> back into FreeBSD, but neither of us is a committer - here's the first one.
>>
>> This moves the check for dtrace trap handlers into the low-level exception
>> handler to prevent recursive entry when the trap routine is instrumented.
>> This fixes several tests which previously panicked including
>> cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/safety/tst.basename.d.
>> The fix is AMD64 only – neither of us has had time to make changes to i386
>> code as we don’t use it here.
>>
>> Also this includes updates to the Makefile for the DTrace tests to
>> categorize which ones pass, which ones fail, which ones aren’t safe to run
>> at all, and which ones sometimes pass and sometimes fail. The list should
>> be correct for both AMD64 and i386. This makes “make”, “make ignore”, and
>> “make flaky” safe to run in /tools/test/dtrace.
>
> Hello,
>
> I'd be happy to help bring these in. I'll probably need some help
> reviewing the first one, but "improve the DTrace test makefile" has been
> on my todo list for a while.
>
> Are they available somewhere?

Sorry, didn't see the attachment. I'll take a look tonight.

-Mark


More information about the freebsd-dtrace mailing list