[Bug 246936] [Patch] Fix LATESTREVISION determination, causes build failure on non-English locales

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Jun 2 13:10:12 UTC 2020


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=246936

            Bug ID: 246936
           Summary: [Patch] Fix LATESTREVISION determination, causes build
                    failure on non-English locales
           Product: Documentation
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Documentation
          Assignee: doc at FreeBSD.org
          Reporter: olivier.freebsd at free.fr

Created attachment 215164
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=215164&action=edit
Patch fixing LATESTREVISION determination

Hi,

Please find attach a patch that fixes LATESTREVISION determination, which
actually fixes "manual" articles/books build (i.e., typing `make` in the right
directory).

The current code has two problems:
1. Git or SVN information retrieval depends on the current locale, and doesn't
work with non-English ones.
2. Fallback for LATESTREVISION most of the time (sometimes works, probable
race) itself fails because PWD is set to document's directory + '/obj', but
sources are in the document's directory.

Point 2 is the most annoying because documentation builds simply fails
(`xsltproc` becomes unable to resolve 'latestrevision.*' variables in, e.g.,
articles). But point 2's failure appears only because of point 1's failure,
which doesn't happen on a machine with English or C locale.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-doc mailing list