About rules on style changes

Dag-Erling Smørgrav des at des.no
Tue Jul 6 14:47:02 UTC 2004


Xin LI <delphij at frontfree.net> writes:
> Hmm... Seems that I have misunderstood the committers' guide, section
> 10.3, which said:
>
> "Do not mix style fixes with new functionality. A style fix is any
> change which does not modify the functionality of the code. Mixing the
> changes obfuscates the functionality change when using cvs diff, which
> can hide any new bugs."

That just means you have to do it in a separate commit.  We do not
generally make style changes for their own sake; instead, we commit
style fixes shortly before or after a functional change.

DES
-- 
Dag-Erling Smørgrav - des at des.no



More information about the freebsd-doc mailing list