whitespace cleanup Q

Dmitry Morozovsky marck at rinet.ru
Tue Aug 10 16:23:41 UTC 2004


On Tue, 10 Aug 2004, Marc Fonvieille wrote:

MF> > preparing for my traditional first set of commits I found that (at least)
MF> > contributors article contains way too much whitespace-only lines:
MF> >
MF> > marck at woozle:~/FreeBSD/doc/en_US.ISO8859-1/articles/contributors> grep -c '^[   ][      ]*$' *sgml
MF> > article.sgml:1
MF> > contrib.386bsd.sgml:95
MF> > contrib.additional.sgml:0
MF> > contrib.committers.sgml:325
MF> > contrib.core.sgml:7
MF> > contrib.corealumni.sgml:26
MF> > contrib.develalumni.sgml:2
MF> > contrib.staff.sgml:0
MF> >
MF> > What is the most preferred way to fix this?
MF> >
MF>
MF> That has been covered many times (see -doc archives etc.)
MF> Most of time whitespace commits are useless, they just add bloat to the
MF> CVS repo.  And since a fix today does not prevent a whitespace addition
MF> on tomorrow...
MF>
MF> contrib.committers.sgml:325 seemed a lot for me.  After a quick check,
MF> it appears that these whitespaces have been added during the article.sgml
MF> split :((
MF> People use to edit this file at least once and just copy&paste a
MF> part, they copy whitespaces without knowing it.  So this file should be
MF> fixed to avoid "spread of whitespaces".
MF>
MF> Few months ago we did a clean of the contrib.additional.sgml file for
MF> the same reason, I'm glad to see no new whitespaces have been added :)
MF>
MF> My opinion is: let fix contrib.committers.sgml, contrib.386bsd.sgml
MF> (95 is a lot too) and maybe contrib.corealumni.sgml, the remaining does
MF> not worth a commit.
MF>
MF> Well this does not prevent us to take care of these problems before
MF> committing anything.

Totally agreed.

I just want to share (and hear) optinions, as my certainly is
not the Rightest one ;-)

Should I prepare these two or three whitespace fixes after my first announcing
commits? What d'you think?

Sincerely,
D.Marck                                     [DM5020, MCK-RIPE, DM3-RIPN]
------------------------------------------------------------------------
*** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck at rinet.ru ***
------------------------------------------------------------------------



More information about the freebsd-doc mailing list