docs/65070: acct(2) patch

[Christian Brueffer]

The following reply was made to PR docs/65070; it has been noted by GNATS.

From: Christian Brueffer <chris at unixpages.org>
To: Marc Silver <marcs at draenor.org>
Cc: FreeBSD-gnats-submit at freebsd.org
Subject: Re: docs/65070: acct(2) patch
Date: Fri, 16 Apr 2004 02:38:02 +0200

 --D6IIOQQv2Iwyp54J
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Fri, Apr 02, 2004 at 12:55:23PM +0100, Marc Silver wrote:
 
 A few comments:
 
 >=20
 > --- acct.2-orig	Fri Apr  2 12:35:55 2004
 > +++ acct.2	Fri Apr  2 12:38:16 2004
 > @@ -75,9 +75,27 @@
 >  .Pp
 >  This call is permitted only to the super-user.
 >  .Sh NOTES
 > -Accounting is automatically disabled when the file system the
 > -accounting file resides on runs out of space; it is enabled when
 > -space once again becomes available.
 > +Accounting is automatically disabled when the file system the accounting
 > +file resides on runs out of space; it is enabled when space once
 > +again becomes available.  These values can be controlled using the
 
 New sentences should start on new lines.  Also "these values" is a bit
 misleading, we haven't talked about any values before.
 
 > +following
 > +.Xr sysctl 8
 > +variables:
 > +.Pp
 > +.Bl -ohang -offset indent
 > +.It kern.acct_chkfreq
 > +.Pq Vt int
 > +Specifies the frequency (in minutes) with which free disk
 > +space should be checked.
 > +.It kern.acct_resume
 > +.Pq Vt int
 > +The percentage of free disk space above which process
 > +accounting will resume.
 > +.It kern.acct_suspend
 > +.Pq Vt int
 > +The percentage of free disk space below which process
 > +accounting will suspend.
 > +.El
 
 This is not very in line with the sysctl lists in other manpages.
 What do you think about the following patch?
 
 Index: acct.2
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /usr/home/ncvs/freebsd/src/lib/libc/sys/acct.2,v
 retrieving revision 1.15
 diff -u -r1.15 acct.2
 --- acct.2      10 Sep 2003 19:24:33 -0000      1.15
 +++ acct.2      16 Apr 2004 00:29:56 -0000
 @@ -78,6 +78,21 @@
  Accounting is automatically disabled when the file system the
  accounting file resides on runs out of space; it is enabled when
  space once again becomes available.
 +The values controlling this behaviour can be modified using the
 following
 +.Xr sysctl 8
 +variables:
 +.Pp
 +.Bl -tag -width ".Va kern.acct_chkfreq"
 +.It Va kern.acct_chkfreq
 +Specifies the frequency (in minutes) with which free disk
 +space should be checked.
 +.It Va kern.acct_resume
 +The percentage of free disk space above which process
 +accounting will resume.
 +.It Va kern.acct_suspend
 +The percentage of free disk space below which process
 +accounting will suspend.
 +.El
  .Sh RETURN VALUES
  On error -1 is returned.
  The file must exist and the call may be exercised only by the
 super-user.
 @@ -112,6 +127,7 @@
  .El
  .Sh SEE ALSO
  .Xr acct 5 ,
 +.Xr accton 8 ,
  .Xr sa 8
  .Sh HISTORY
  The
 
 
 - Christian
 
 --=20
 Christian Brueffer	chris at unixpages.org	brueffer at FreeBSD.org
 GPG Key:	 http://people.freebsd.org/~brueffer/brueffer.key.asc
 GPG Fingerprint: A5C8 2099 19FF AACA F41B  B29B 6C76 178C A0ED 982D
 
 --D6IIOQQv2Iwyp54J
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.4 (FreeBSD)
 
 iD8DBQFAfyrqbHYXjKDtmC0RAi8QAKCtcVQA9+kDPNEoQykVxMSVyEzFOwCgkKqN
 VPLca3U5wVx8/TeBdCIzx5A=
 =yKy3
 -----END PGP SIGNATURE-----
 
 --D6IIOQQv2Iwyp54J--