Did I get this right?

[Ceri Davies]

On Thu, Nov 13, 2003 at 08:34:48AM -0800, Wes Peters wrote:
> On Wednesday 12 November 2003 12:20, Ceri Davies wrote:
> > On Wed, Nov 12, 2003 at 09:53:35AM -0800, Wes Peters wrote:
> > > I added a section about CUPS, mostly cribbed from the pkg-descr, to
> > > the handbook printing chapter.  I'm pretty fuzzy with doc tools and
> > > such, and therefore need a thorough review.  Please have at me over
> > > the attached diff, and thanks in advance.  ;^)
> >
> > Hi Wes,
> >
> > Thanks for knocking this together, but just to be cruel I'm going to
> > pick your patch apart - don't let it put you off ;-)
> 
> No, thanks for the review.  Sometimes just knowing what to look for is 
> half the challenge.  Attached you will find my second attempt with all 
> the problems you noted fixed, plus an additional <application> I 
> spotted as I was editing.  Thanks!

Looks good for committing, but I still have a couple of whitespace nits,
I'm afraid, which are inline below.

> Index: chapter.sgml
> ===================================================================
> RCS file: /home/dcvs/doc/en_US.ISO8859-1/books/handbook/printing/chapter.sgml,v
> retrieving revision 1.81
> diff -u -w -u -w -r1.81 chapter.sgml
> --- chapter.sgml	5 Nov 2003 10:36:55 -0000	1.81
> +++ chapter.sgml	13 Nov 2003 16:32:54 -0000
> @@ -4585,6 +4585,29 @@
>  	      url="http://www.lprng.org/"></ulink>.</para>
>  	</listitem>
>        </varlistentry>
> +      <varlistentry>
> +	<term>CUPS</term>
> +
> + 	<indexterm><primary>CUPS</primary></indexterm>	  
> +	<listitem>
> +	  <para><application>CUPS</application>, the Common UNIX Printing
> +	    System, provides a portable printing layer for &unix;-based
> +	    operating systems.  It has been developed by Easy Software
> +	    Products to promote a standard printing solution for all &unix;
> +	    vendors and users.</para>
> +	  <para><application>CUPS</application> uses the Internet Printing

Please add another newline between </para> and <para>.

> +	    Protocol (<acronym>IPP</acronym>) as the basis for managing
> +	    print jobs and queues. The Line Printer Daemon
                                  ^
Add another space.

> +	    (<acronym>LPD</acronym>) Server Message Block
> +	    (<acronym>SMB</acronym>), and AppSocket (a.k.a. JetDirect)
> +	    protocols are also supported with reduced functionality.  CUPS
> +	    adds network printer browsing and PostScript Printer Description
> +	    (<acronym>PPD</acronym>) based printing options to support
> +	    real-world printing under &unix;.</para>
> +	  <para>The main site for <application>CUPS</application> is <ulink

Add another newline after </para>.

That's it, cheers.

Ceri

-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-doc/attachments/20031113/23790a69/attachment.sig>