Log view diff line

VilleSkyttä scop at FreeBSD.org
Fri May 6 03:31:53 PDT 2005


On Thu, 2005-05-05 at 14:09 -0700, Jerry Nairn wrote:
> Suggested changes to diff links in the log view:
> 
> On the four lines which have:
> 
> $diff = ''; $printed = 1;
> 
> I have changed it to:
> 
> $diff = ','; $printed = 1;
> 
> I feel it is clearer with the separator in it. Other characters or
> combinations of characters might be better.

Agreed.

> I changed the string ' next main ' to ' to next main ' to be
> consistent with the other links, ' to previous ' and ' to branchpoint
> '.

Good catch.

Thoughts about the attached patch?  It uses a semicolon for separating
the diff link "categories", moves the "to" to be only at the beginning
of the line, and adds parens around the displayed revision numbers.  I'm
not sure if the parens add any value though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diffs.patch
Type: text/x-patch
Size: 2436 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-cvsweb/attachments/20050506/c39fe269/diffs.bin


More information about the freebsd-cvsweb mailing list