Patch to cvsweb?
Bryce Nesbitt (mailing list account)
bryce1 at obviously.com
Sun Jan 4 19:43:12 PST 2004
I agree that using CVS's "b" (binary) flag is a good hint.
But why hard code the response? For each combination of binary flag and
mime type, I might want select allowable diff and download types
independently:
Diff as:
text
colored
side-by-side
shape_diff.exe (external)
exell_diff.exe (external)
Download as:
Native mime type (e.g. "application/msword")
As text
The default could be to enable everything except the
external diff utilities.
-Bryce
Ville Skyttä wrote:
>All true. Currently I'm thinking about using CVS's keyword expansion
>mode to "detect" whether a file is a text file in the first place (if
>possible everywhere, haven't checked yet). If a file is checked in
>using the "b" (binary) mode, we treat it as binary and will not offer
>HTMLized view of it, or a regular diff. On the other hand, if it does
>not have the "b" flag set, we'll show the "(download as text)" link if
>the resolved MIME type is not "text/*", ditto show many diff
>links/options including a "regular diff" link if the file has dedicated
>diff tool(s) but is a text file etc etc, lots of work to do.
>
>>Bryce wrote:
>>The issue is complex. For an XML file I might want the choice to diff
>>it as a text file, OR
>>use a generic XML diff utility, OR using a specilized utility that
>>understands the content.
>>As a system administrator I might want to prohibit diffing some files
>>as text, because I know
>>the results will be nonsense.
>>
>>
>
>
More information about the freebsd-cvsweb
mailing list