couple minor bugs [correct diff]

Christophe Kalt kalt at taranis.org
Fri May 30 10:45:29 PDT 2003


[If the moderator's swift enough, s/he'll suppress my previous post
with the broken diff.  Not sure how it ever worked for me ;-)]

You need to set stdout to be automatically flushed to avoid
having a child (such as cvsgraph) flushing the same content
as the parent a second time.

a "$| = 1;" well placed (may be in BEGIN) does the trick.

The attached diff also fixes a small problem with DoGraphView.

Finally, having working annotations w/o read-write access is
awesome, finally, thanks!  You may want to update the comments
for $allow_annotate.

Christophe
-------------- next part --------------
--- /tmp/foo/cvsweb/cvsweb.cgi	2003-05-30 12:17:20.171957009 -0400
+++ cvsweb.cgi	2003-05-30 13:25:30.821001000 -0400
@@ -136,6 +136,8 @@
   $LOG_REVSEPARATOR  = qr/^-{28}$/o;
 
   $CvsWebMarkupRE = qr/^text\/(x-cvsweb|vnd\.viewcvs)-markup$/io;
+
+  $| = 1;
 }
 
 # -----------------------------------------------------------------------------
@@ -2775,9 +2777,9 @@
   my $mapname = 'CvsGraphMap';
   my $ctype = $defaultViewable ? '&content-type=text/x-cvsweb-markup' : '';
 
-  printf(<<EOF, $title, $mapname, $rev, $title);
+  printf(<<EOF, $title, $mapname, $cvstree, $rev, $title);
 <h3 style="text-align: center">%s</h3>
-<div align="center"><img border="0" usemap="#%s" src="?graph=%s&amp;makeimage=1" alt="%s"></div>
+<div align="center"><img border="0" usemap="#%s" src="?cvsroot=%s&graph=%s&amp;makeimage=1" alt="%s"></div>
 EOF
 
   my @graph_cmd =


More information about the freebsd-cvsweb mailing list