after update to r368166: no sound recording

[Matthias Apitz]

El día lunes, diciembre 14, 2020 a las 10:16:21a. m. +0100, Matthias Apitz escribió:

> I did a step by step down grading with 'svn up -r..... hdaa.c hdaa.h'
> (only these two files), starting from r368166 down to the following revisions:
> 
> r368166: no recording from pcm1
> 
> r358333: no recording from pcm1
> 
> r350078: no recording from pcm1
> 
> r337043: recording is fine
> 
> I've cc'ed now the commiters of the r358333 and r350078. kaktus@ and sbruno@
> please check the issue https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251727
> and this mail thread in current@

I have nailed down the problem and locally fixed it with this:

# svn diff sys/dev/sound/pci/hda/hdaa.c
Index: sys/dev/sound/pci/hda/hdaa.c
===================================================================
--- sys/dev/sound/pci/hda/hdaa.c	(revisión: 368166)
+++ sys/dev/sound/pci/hda/hdaa.c	(copia de trabajo)
@@ -6598,6 +6598,7 @@
 	devinfo->newgpo = -1;
 	callout_init(&devinfo->poll_jack, 1);
 	devinfo->poll_ival = hz;
+	devinfo->init_clear = 1;    /* added by guru at unixarea.de */

 	hdaa_lock(devinfo);
 	res = hda_command(dev,

because there seems to be no code to set devinfo->init_clear from
loader.conf; there is in hdaa.c:

       SYSCTL_ADD_INT(device_get_sysctl_ctx(dev),
            SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), OID_AUTO,
            "init_clear", CTLFLAG_RW,
            &devinfo->init_clear, 1,"Clear initial pin widget configuration");

but I don't see any function like hdaa_init_clear_handler() which writes
the value to devinfo->init_clear; 

Am I mistaken?

	matthias


-- 
Matthias Apitz, ✉ guru at unixarea.de, http://www.unixarea.de/ +49-176-38902045
Public GnuPG key: http://www.unixarea.de/key.pub