building head -r338675 with devel/amd64-gcc: /usr/local/x86_64-unknown-freebsd12.0/bin/ld: warning: -z ifunc-noplt ignored

[Warner Losh]

On Fri, Sep 21, 2018 at 9:30 PM Rebecca Cran <rebecca at bluestop.org> wrote:

> On 9/21/18 9:09 PM, Warner Losh wrote:
>
> > On Fri, Sep 21, 2018 at 9:02 PM Rebecca Cran via freebsd-toolchain <
> > freebsd-toolchain at freebsd.org> wrote:
> >
> >> On 9/21/18 4:06 PM, Mark Johnston wrote:
> >>> https://reviews.freebsd.org/D17279 for anyone else that would like to
> >>> review.
> >>
> >> Is that possibly related to the error I'm getting trying to build
> >> -CURRENT on 11.2?
> >>
> >>
> >> make[4]: "/usr/home/bcran/workspace/freebsd/lib/libc/Makefile" line 26:
> >> amd64 libc requires linker ifunc support
> >>
> > Yea, that should absolutely work. If it doesn't, that's a big big
> problem.
>
>
> I see, it was introduced earlier today in lib/libc/Makefile:
>
>
> commit ef8030831eccec4e481a1766fc1c67f7cadadac9
> Author: emaste <emaste at FreeBSD.org>
> Date:   Fri Sep 21 17:49:37 2018 +0000
>
>     libc: require ifunc-capable linker for amd64/i386
>
>     We expect to introduce optimized libc routines in the near future,
>     which requires use of a linker that supports ifuncs.
>
>     Approved by:    re (gjb, kib)
>     Sponsored by:   The FreeBSD Foundation
>
>
> And /usr/bin/ld -v on my 11.2 system says:
>
>
> GNU ld 2.17.50 [FreeBSD] 2007-07-03
>

What does ld.lld say?

However, it shouldn't matter: we don't build libc until *AFTER* we build
ld.lld, so this error is bogusly triggering. I suspect that it needs to be
limited to only building targets, since tree traversal ones, as well as
install targets don't have this dependency.

Warner