[PATCH] Recent libm additions

Matthew Macy mmacy at freebsd.org
Sun Jul 15 18:03:54 UTC 2018


On Sun, Jul 15, 2018 at 10:55 AM, Warner Losh <imp at bsdimp.com> wrote:
> On Sun, Jul 15, 2018, 11:23 AM K. Macy <kmacy at freebsd.org> wrote:
>
>> >
>> > Well, actually, the functions in polevll.c should have been copied
>> > into ld80/e_powl.c, and polevall.c should never have been committed.
>> > Unfortunately, the code was not reviewed for correctness.
>>
>> That is not correct. Please stop repeating it. Bruce Evans and John
>> Baldwin were both looped in. Neither made this observation.
>>
>
> Steve is the fp guy these days. And it wasn't reviewed by him. He's mad you
> cut him out of the loop. Arguing about pedantic points of process does no
> one any good.

Thanks for the tip. I'm sorry. I was under the impression that he gave
up his bit: https://reviews.freebsd.org/rD46886

So we have a maintainer who has opted to not have a bit. So be it.

Nonetheless, reviews.freebsd.org is the established channel by which
the project does code reviews. I stand by my recommendation and will
add him to reviews in the future.


More information about the freebsd-current mailing list