[PATCH] Recent libm additions

Steve Kargl sgk at troutmask.apl.washington.edu
Sun Jul 15 17:17:39 UTC 2018


On Sun, Jul 15, 2018 at 11:00:41AM -0600, Ian Lepore wrote:
> On Sun, 2018-07-15 at 08:06 -0700, Steve Kargl wrote:
> > Index: ld80/e_powl.c
> > ===================================================================
> > --- ld80/e_powl.c	(revision 336304)
> > +++ ld80/e_powl.c	(working copy)
> > @@ -77,6 +77,7 @@
> >  #include 
> >  
> >  #include "math_private.h"
> > +#include "polevll.c"
> 
> If a file contains inline function definitions and is intended only to
> be included into another file and not compiled separately, shouldn't
> its name be spelled polevll.h ?
> 

Well, actually, the functions in polevll.c should have been copied
into ld80/e_powl.c, and polevall.c should never have been committed.
Unfortunately, the code was not reviewed for correctness.  I've
made the minimum changes to address the two issues I've noted.
Feel free to either copy the functions and delete the polevall.c
or rename it.

-- 
Steve


More information about the freebsd-current mailing list