mount_smbfs gives error when stored crypted pw is used

[O. Hartmann]

Am Wed, 7 Jun 2017 19:22:34 +0200
Matthias Apitz <guru at unixarea.de> schrieb:

> El día miércoles, junio 07, 2017 a las 02:35:31p. m. +0200, Matthias Apitz escribió:
> 
> > I have located the bug in /usr/src/contrib/smbfs/lib/smb/subr.c 
> > 
> > The printf(3C) calls have been added for debugging; the bug is the
> > addition of 13 after crypting every char which let the mask used in ^ operation
> > exceeding 256, i.e. more than one byte, if the string to be crypted is long
> > enough. The two lines added:
> > 
> >                 if (pos > 256)
> >                     pos = pos-256;
> > 
> > fixes this issue and the crypting/decypting works fine; see below;
> > 
> > I'll later file a PR and propose the patch;  
> 
> The PR was already made in 2009:
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=132302 has a patch attached (nearly
> the same solution as I have found), but was never ci'ed :-(
> 
> 	matthias
> 
> 

Wow ... that is, simply ... not very good! :-(

High quality!

-- 
O. Hartmann

Ich widerspreche der Nutzung oder Übermittlung meiner Daten für
Werbezwecke oder für die Markt- oder Meinungsforschung (§ 28 Abs. 4 BDSG).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 313 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20170607/c1f49f95/attachment.sig>