[bmake] bmake sigint handling causing tty corruption

Simon J. Gerraty sjg at juniper.net
Thu Jul 20 02:00:36 UTC 2017


Hi Dmitry

Thanks for the detailed report.

Will take a look....

> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215572

> Now to fix this, I suggest that instead of killing itself, make should
> signal all its childs carefully and wait() on them, only then die
> itself.
> 
> Now after a quick glance at bmake sources it seems like the jobs control
> code
> 
> https://svnweb.freebsd.org/base/head/contrib/bmake/job.c?revision=317239&view=markup#l2633
> 
> does the very same thing that I've just described, however bmake is run
> in compat mode by default, and CompatInterrupt does exactly what ktrace
> shows - it just kills itself.
> 
> https://svnweb.freebsd.org/base/head/contrib/bmake/compat.c?revision=310304&view=markup#l180
> 
> So, to fix this problem it seems that CompatInterrupt should be improved
> as described above.


More information about the freebsd-current mailing list