WARNING: [r299313] make installworld overwrites master.passwd and group!

[Bryan Drewery]

On 5/9/16 10:47 PM, Glen Barber wrote:
> On Tue, May 10, 2016 at 07:15:57AM +0200, O. Hartmann wrote:
>> On a most recent buildworld with make installworld/installkernel I faced the
>> fact that all the entries in /etc/master.passwd and /etc/group were reset to
>> the initial/vanilla values. Luckily, I was able to fetch backups
>> from /var/backups.
>>
>> I do not know which essential config files additionally got altered or reset to
>> the initial values.
>>
>> This bug is present on all systems I maintain and I ran into this problem on
>> approx ten boxes this morning.
>>
>> What is up here?
>>
> 
> Confirmed.  This is my fault, misreading what I thought was a mismerge
> (r299292).
> 
> Reverting it now.  I apologize for the inconvenience this caused you,
> and appreciate the prompt report on the issue.  It is reverted in
> r299317.


I've made the same mistake before.

Here's a patch that should be right:
https://people.freebsd.org/~bdrewery/patches/Makefile.inc1-restage-reinstall.diff


-- 
Regards,
Bryan Drewery