r288669 breaks ports building with USE_GCC=yes

[Jason Unovitch]

On Mon, Oct 12, 2015 at 4:16 PM, Pedro Giffuni <pfg at freebsd.org> wrote:
> Hello;
>
> On 12/10/2015 02:56 p.m., Justin Hibbits wrote:
>>
>> The default ports gcc for USE_GCC is still 4.8, which does not support
>> -fstack-protector-strong.  This breaks several ports including (from
>> my poudriere run): libfpx and qt4-sqlite3-plugin.
>>
>> - Justin
>
>
> r288669 only applies to base. It was tested with an exp-run and there were
> no
> failures so this is something wrong in your setup.
>
> This said, --stack-protector-strong was being considered for ports, so
> portmgr
> should consider changing USE_GCC to 4.9 before that.
>
> regards,
>
> Pedro.
>
> _______________________________________________

I've been toying with a patch to use -fstack-protector-strong when
available with the base compilers as well as detecting the ports GCC
version and either using -fstack-protector-strong or falling back to
-fstack-protector.  I haven't put the patch up for review yet but in
my opinion we should have lang/gcc be 4.9 by default before we can
realistically consider an exp-run.

Jason