pedantic compiler warnings: double semicolons, function to data pointers

[Luigi Rizzo]

While trying to compile some of my (kernel) code in different environments,
i noticed a couple of errors that perhaps might be worth fixing

- extra semicolons. These come either from explicit repetitions in the code
  (see the output of a grep at the end of this message),
  or sometimes from the epansion of macros such as BITSET_DEFINE()


- conversion between function and data pointers. One is in mbuf.h

  m->m_ext.ext_free = m->m_ext.ext_arg1 = m->m_ext.ext_arg2 = NULL;


Shuold we care/bother to fix these as we step through them ?

cheers
luigi

crypto/openssh/openbsd-compat/bsd-cray.c:	debug("Setting MLS labels.");;
crypto/heimdal/appl/telnet/libtelnet/encrypt.c:    buflen -= 2;;
crypto/heimdal/lib/krb5/aes-test.c:	    continue;;
crypto/heimdal/lib/krb5/aes-test.c:	    continue;;
crypto/heimdal/lib/hdb/hdb-ldap.c:	bv[i] = ber_memalloc(sizeof(**bv));;
crypto/heimdal/lib/hx509/print.c:		       "\teku-%d: %s\n", i, str);;
crypto/openssl/engines/ccgost/gostsum.c:        int failcount = 0, count = 0;;
crypto/openssl/apps/ca.c:        BIO_printf(bio_err, "Type          :%s\n", p);;
crypto/openssl/apps/s_client.c:            sbuf_len -= i;;
crypto/openssl/crypto/asn1/x_crl.c:                    break;;
lib/libfetch/common.c:			    delta.tv_usec / 1000;;
lib/libc/db/btree/bt_overflow.c:	for (last = NULL, p = dbt->data, sz = dbt->size;;
sbin/fsck_ffs/globs.c:	bzero(&startprog, sizeof(struct timespec));;
sys/geom/label/g_label_msdosfs.c:		for (offset = fat_BytesPerSector * fat_FirstDataSector;;
sys/boot/arm/at91/libat91/sd-card.c:	AT91C_BASE_PDC_MCI->PDC_RCR  = SD_BLOCK_SIZE / 4;;
sys/amd64/vmm/io/vlapic.c:		return ((&lapic->lvt_timer) + i);;
sys/ofed/drivers/net/mlx4/en_tx.c:	int frags = tx_info->nr_segs;;
sys/ofed/drivers/infiniband/hw/mthca/mthca_provider.c:	n = mr->umem->nmap;;
sys/sys/systm.h:void	explicit_bzero(void *, size_t) __nonnull(1);;
sys/arm/arm/vm_machdep.c:	td2->td_md.md_saved_cspr = PSR_SVC32_MODE;;
sys/arm/arm/trap-v6.c:			tf->tf_r0 = EFAULT;;
sys/arm/amlogic/aml8726/aml8726_sdxc-m8.c:			stop = start + 4;;
sys/net80211/ieee80211_superg.c:		error = ieee80211_parent_xmitpkt(ic, m);;
sys/pc98/cbus/olpt.c:		sc->sc_backoff = hz / LPTOUTINITIAL;;
sys/contrib/dev/ath/ath_hal/ar9300/ar9300_reset.c:                    cl_tab_reg += 4;;
sys/contrib/ipfilter/netinet/ip_state.c:	hv += tcp->th_dport;;
sys/contrib/ipfilter/netinet/ip_state.c:	hv += tcp->th_sport;;
sys/contrib/ipfilter/netinet/ip_frag.c:	ipf_frag_softc_t *softf = softc->ipf_frag_soft;;
sys/contrib/ngatm/netnatm/sig/sig_party.c:	p->state = UNI_EPSTATE_NULL;;
sys/cam/ctl/ctl.c:		ctsio->kern_data_ptr = malloc(len, M_CTL, M_WAITOK);;
sys/cam/ctl/ctl.c:		ctsio->kern_data_ptr = malloc(len, M_CTL, M_WAITOK);;
sys/cam/scsi/scsi_da.c:	struct da_softc *softc = (struct da_softc *)periph->softc;;
sys/cddl/dev/fbt/fbt.c:	const Elf_Sym *symp = lc->symtab;;
sys/cddl/dev/fbt/fbt.c:	const ctf_header_t *hp = (const ctf_header_t *) lc->ctftab;;
sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c:			    va+off, DMU_READ_PREFETCH);;
sys/cddl/contrib/opensolaris/uts/common/dtrace/dtrace.c:	processorid_t cpu = 0;;
sys/dev/stge/if_stge.c:	for (cons = sc->sc_cdata.stge_tx_cons;;
sys/dev/cxgbe/iw_cxgbe/mem.c:                return ERR_PTR(-ENOMEM);;
sys/dev/oce/oce_sysctl.c:				pimg->img_offset =  13107200;;
sys/dev/iscsi/iscsi.h:	struct cv			is_login_cv;;
sys/dev/netmap/netmap_kern.h:void generic_rx_handler(struct ifnet *ifp, struct mbuf *m);;
sys/dev/mpr/mpr_user.c:			dir = BUS_DMASYNC_POSTWRITE;;
sys/dev/hptnr/hptnr_os_bsd.c:	return (HPT_U32)pci_cfgregread(bus, dev, func, reg, 4);;
sys/dev/hyperv/netvsc/hv_net_vsc.c:	netvsc_dev *net_dev = sc->net_dev;;
sys/dev/hyperv/netvsc/hv_net_vsc.c:	netvsc_dev *net_dev = sc->net_dev;;
sys/dev/hyperv/netvsc/hv_net_vsc.c:	netvsc_dev *net_dev = sc->net_dev;;
sys/dev/netmap_new/netmap_kern.h:void generic_rx_handler(struct ifnet *ifp, struct mbuf *m);;
sys/net/ieee8023ad_lacp.c:		lp->lp_partner = lacp_partner_admin_optimistic;;
tools/regression/rpcsec_gss/rpctest.c:	gethostname(hostname, sizeof(hostname));;
usr.sbin/fstyp/msdosfs.c:		for (offset = fat_BytesPerSector * fat_FirstDataSector;;
usr.sbin/ctladm/ctladm.c:	char *max_data_segment_length;;
usr.sbin/ctladm/ctladm.c:	char *offload;;