broken release generation when

[Slawa Olhovchenkov]

On Sat, Jun 13, 2015 at 02:35:46PM +0000, Glen Barber wrote:

> [re@ CC'd]
> 
> On Sat, Jun 13, 2015 at 02:34:37PM +0200, Oliver Pinter wrote:
> > Hi all!
> > 
> > We got build error with custom BRANCH= in newvers.sh. The release
> > process unable to generate the ISO files but they not stopped with
> > error, just ignore them, and continue with memstick images.
> > 
> > 
> > cp /jenkins/workspace/HardenedBSD-stable-master-amd64/release/rc.local
> > bootonly/etc
> > sh /jenkins/workspace/HardenedBSD-stable-master-amd64/release/amd64/mkisoimages.sh
> > -b 11_0_CURRENT_HARDENEDBSD_amd64_BO bootonly.iso bootonly
> > 100+0 records in
> > 100+0 records out
> > 409600 bytes transferred in 0.007822 secs (52361998 bytes/sec)
> > newfs_msdos: cannot get number of sectors per track: Operation not supported
> > newfs_msdos: cannot get number of heads: Operation not supported
> > newfs_msdos: trim 44 sectors to adjust to a multiple of 63
> > /dev/md0: 717 sectors in 717 FAT12 clusters (512 bytes/cluster)
> > BytesPerSec=512 SecPerClust=1 ResSectors=1 FATs=2 RootDirEnts=512
> > Sectors=756 Media=0xf8 FATsecs=3 SecPerTrack=63 Heads=1 HiddenSecs=0
> > makefs: error: The Disk Label must be at most 32 characters long
> > usage: makefs [-t fs-type] [-o fs-options] [-d debug-mask] [-B endian]
> > 	[-S sector-size] [-M minimum-size] [-m maximum-size] [-s image-size]
> > 	[-b free-blocks] [-f free-files] [-F mtree-specfile] [-xZ]
> > 	[-N userdb-dir] image-file directory | manifest [extra-directory ...]
> > 
> 
> I think at this point either:
> 
> 1) VOLUME_LABEL should be removed; or
> 2) VOLUME_LABEL should be only set if 'uname -s' returns 'FreeBSD'.
> 
> There have been multiple reports of issues with this, and the workaround
> for edge cases is getting far too ugly at this point, so I prefer option
> (1).

makefs must truncate label and don't return error.