Why shoud we cause panic in scsi_da.c?
Hans Petter Selasky
hps at selasky.org
Mon Jul 13 08:38:04 UTC 2015
On 07/13/15 10:11, Kohji Okuno wrote:
> Hi,
>
> Could you comment on my quesion?
>
> Best regards,
> Kohji Okuno
>
>> Hi,
>>
>> I found panic() in scsi_da.c. Please find the following.
>> I think we should return with error without panic().
>> What do you think about this?
>>
>> scsi_da.c:
>> 3018 } else if (bp != NULL) {
>> 3019 if ((done_ccb->ccb_h.status & CAM_DEV_QFRZN) != 0)
>> 3020 panic("REQ_CMP with QFRZN");
>>
Hi,
It looks to me more like an KASSERT() is appropriate here.
Might be some people which can answer this are on vacation currently.
--HPS
More information about the freebsd-current
mailing list