XOR pt. 2

Michael McConville mmcco at mykolab.com
Fri Dec 11 19:42:23 UTC 2015


Note that IFCAP_HWCSUM has two bits set. Because of this, it doesn't XOR
cleanly in the current if-else condition, but I'm not sure whether that
was intended. I just wanted to pass this by people in case it was a
logical bug.


--- dev/ixgb/if_ixgb.c.orig
+++ dev/ixgb/if_ixgb.c
@@ -599,10 +599,7 @@ ixgb_ioctl(struct ifnet * ifp, IOCTL_CMD
 		}
 #endif /* DEVICE_POLLING */
 		if (mask & IFCAP_HWCSUM) {
-			if (IFCAP_HWCSUM & ifp->if_capenable)
-				ifp->if_capenable &= ~IFCAP_HWCSUM;
-			else
-				ifp->if_capenable |= IFCAP_HWCSUM;
+			ifp->if_capenable ^= IFCAP_HWCSUM;
 			if (ifp->if_drv_flags & IFF_DRV_RUNNING)
 				ixgb_init(adapter);
 		}


More information about the freebsd-current mailing list