Early use of log() does not end up in kernel msg buffer

Eric Badger eric at badgerio.us
Tue Apr 7 00:39:45 UTC 2015


On 04/06/2015 04:11 PM, Poul-Henning Kamp wrote:
> --------
> In message <2033248.Eu3RHS8lTG at ralph.baldwin.cx>, John Baldwin writes:
>
>> I think phk@ broke this back in 70239.  Before that the log() function did
>> this:
>>
>> log()
>> {
>>
>> 	/* log to the msg buffer */
>> 	kvprintf(fmt, msglogchar, ...);
>>
>> 	if (!log_open) {
>> 		/* log to console */
>> 		kvprintf(fmt, putchar, ...);
>> 	}
>> }
>>
>> I think your patch is fine unless phk@ (cc'd) has a reason for not wanting to
>> do this.
> The reason was systems not running syslog having slow serial consoles.
>

Correct me if I've misunderstood, but that doesn't seem to matter here; 
the proposed change adds logging to the message buffer but leaves 
logging to the console (when no syslog is listening) unchanged.

Eric


More information about the freebsd-current mailing list