[RFC] remove dead code from link_elf.c

Konstantin Belousov kostikbel at gmail.com
Thu May 15 13:50:13 UTC 2014


On Thu, May 15, 2014 at 03:36:51PM +0200, Oliver Pinter wrote:
> Hi all!
> 
> I found that the SPARSE_MAPPING used only in sys/kern/link_elf.c file,
> and no other place in kernel, nor in generated codes in /usr/obj/...
> 
> op at pandora-d opBSD.git> git grep -i SPARSE_MAPPING
> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING
> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING
> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING
> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING
> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING
> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING
> sys/kern/link_elf.c:#ifdef SPARSE_MAPPING
> 
> I proposed to remove the old/dead codes. Patch attached. Tested on amd64.

I agree that SPARSE_MAPPING could go away.  But your testing is void,
since link_elf.c is practically not used on amd64, which utilizes object
file format for klds.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20140515/2d110688/attachment.sig>


More information about the freebsd-current mailing list