domain_add(xxx) after domainfinalize...

[John-Mark Gurney]

So, I have a laptop that devd loads the bluetooth module every time..

This means I get the following error on every boot:
WARNING: attempt to domain_add(bluetooth) after domainfinalize()
WARNING: attempt to domain_add(netgraph) after domainfinalize()

Is there any real benefit to this warning?  I just looked at the code,
and the domain gets added despite the warning...

Also, it looks like the pervious warning, we should just make that an
if/panic since it's clearly a programming bug, or kill the ifndef
INVARIANTS...

Index: uipc_domain.c
===================================================================
--- uipc_domain.c       (revision 266964)
+++ uipc_domain.c       (working copy)
@@ -227,15 +227,6 @@
                printf("WARNING: attempt to domain_add(%s) before "
                    "domaininit()\n", dp->dom_name);
 #endif
-#ifdef notyet
-       KASSERT(domain_init_status < 2,
-           ("attempt to domain_add(%s) after domainfinalize()",
-           dp->dom_name));
-#else
-       if (domain_init_status >= 2)
-               printf("WARNING: attempt to domain_add(%s) after "
-                   "domainfinalize()\n", dp->dom_name);
-#endif
        mtx_unlock(&dom_mtx);
 }
 

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."