gperf/src/options.cc -- quiesce clang warnings -Wlogical-op-parentheses

Sean Bruno sean_bruno at yahoo.com
Sat Oct 26 15:05:23 UTC 2013


On Fri, 2013-10-25 at 10:04 -0400, Sean Bruno wrote:
> On Fri, 2013-10-25 at 06:38 -0400, David Chisnall wrote:
> > > 
> > > I'm simply trying to address the warnings that appear due to clang.
> > I
> > > find the builds very noisy and if there's a better way to address
> > this
> > > issue, I'm totally open to suggestions.
> > 
> > Well, for contrib code that isn't going to be around for much longer
> > like gperf, the best thing to do is probably just stick
> > -Wno-logical-op-parentheses in the CFLAGS.  Alternatively, adding the
> > brackets as it suggested to indicate precedence is simple.
> > 
> > David 
> 
> Agreed.  Thank you for patience in dealing with me. :-)
> 
> I will go with my original patch that simply puts parens where they can
> be picked up and leave the flow of the code alone.
> 
> http://lists.freebsd.org/pipermail/freebsd-current/2013-October/045644.html
> 
> sean


commited at SVN r257160

sean
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20131026/dc09ac2c/attachment.sig>


More information about the freebsd-current mailing list