Buildworld broken with WITHOUT_DYNAMICROOT=yes in src.conf

[Dimitry Andric]

On 25 Nov 2013, at 08:51, Konstantin Belousov <kostikbel at gmail.com> wrote:
> On Sun, Nov 24, 2013 at 11:48:54PM -0500, Glen Barber wrote:
...
>> Index: Makefile
>> ===================================================================
>> --- Makefile      (revision 258538)
>> +++ Makefile      (working copy)
>> @@ -42,6 +42,9 @@
>> 
>> DPADD=	${LIBTERMCAP} ${LIBCRYPT}
>> LDADD=	-ltermcap -lcrypt
>> +.if ${MK_ICONV} != "no" && ${MK_DYNAMICROOT} != "yes"
>> +LDADD+=    -lc_nonshared
>> +.endif
>> 
>> LINKS=	${BINDIR}/csh ${BINDIR}/tcsh
>> 
> 
> No, this is wrong.  As is, static linking is broken and the hack above
> only fixes one case.
> 
> What is needed is inclusion of the lib/libc_nonshared object files into
> static libc.a.  I am not sure how to express this in our build system.

Hi Kostik,

You can add the additional object files to ${STATICOBJS}.  These will
only be built for the static and profiled libraries.  See for example
gnu/lib/libgcc/Makefile or lib/libc++/Makefile.

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 203 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/freebsd-current/attachments/20131125/1a0411e8/attachment.sig>