new Xorg (KMS, etc.) for Radeon 9600
John Baldwin
jhb at freebsd.org
Mon Dec 23 19:43:56 UTC 2013
On Wednesday, December 18, 2013 2:43:28 pm Adrian Chadd wrote:
> [snip]
>
> So the standard trop of UNLOCK/WORK/RELOCK is pretty dangerous.
> There's no state re-validation going on when you re-acquire that lock.
> So, although it meets the lock requirements, it may not be 'correct'.
>
> It's scattered throughout the code base (wifi drivers aren't an
> exception here either, sigh.)
>
> Just something to keep in mind when you validate the 'correctness' of
> this kind of lock hack.
Agreed. It needs fixing, but the fix needs to be correct.
--
John Baldwin
More information about the freebsd-current
mailing list