Spurious witness warning when destroying spin mtx
rysto32 at gmail.com
Sat Nov 24 15:46:19 UTC 2012
On Sat, Nov 24, 2012 at 10:01 AM, Attilio Rao <attilio at freebsd.org> wrote:
> I seriously wonder why right now we don't assume the lock is unheld.
> There are likely historically reasons for that, but I would like to
> know which one are those and eventually fix them out.
> FWIK, all the other locking primitives assume the lock is already
> unheld when destroying and I think it would be good to have that for
> mutexes as well.
> Can you please show which lock triggers the panic you saw?
It was taskqueue_free:
taskqueue_free(struct taskqueue *queue)
queue->tq_flags &= ~TQ_FLAGS_ACTIVE;
KASSERT(TAILQ_EMPTY(&queue->tq_active), ("Tasks still running?"));
KASSERT(queue->tq_callouts == 0, ("Armed timeout tasks"));
More information about the freebsd-current