The current libc/locale/toupper.c is mistaken

Dimitry Andric dim at FreeBSD.org
Thu May 10 10:03:53 UTC 2012


On 2012-05-10 11:02, Kohji Okuno wrote:
> I think that libc/locale/toupper.c is mistaken.
> Could you check it?
> 
> @@ -51,7 +51,7 @@ ___toupper_l(c, l)
>  {
>         size_t lim;
>         FIX_LOCALE(l);
> -       _RuneRange *rr = &XLOCALE_CTYPE(l)->runes->__maplower_ext;
> +       _RuneRange *rr = &XLOCALE_CTYPE(l)->runes->__mapupper_ext;
>         _RuneEntry *base, *re;
>  
>         if (c < 0 || c == EOF)

Yes, this definitely looks like a copy/paste error, introduced here:

http://svnweb.freebsd.org/base/head/lib/libc/locale/toupper.c?r1=165903&r2=227753

I'll commit the fix tonight (CEST), if David isn't faster than me. :)

Thanks!


More information about the freebsd-current mailing list