[PATCH] Add locking to twe(4) so it no longer uses Giant
Mike Tancsa
mike at sentex.net
Tue Aug 7 14:11:08 UTC 2012
On 8/3/2012 5:26 PM, John Baldwin wrote:
>> If there's a tool for poking at the drives/controller, I would use that, plus camcontrol. Of course you want a data intensive workload
> (iometer/iozone/xdd with async and sync mode, random reads and sequential reads, etc), and maybe resort to manual testing like pulling drives
> (power, data) if you don't mind creating failures. If you have some failed/failing drives kicking around, that would be a good test as well (see
> that all/some of the failure paths are properly stimulated).
>
> 3dm2 testing would be good for the ioctl handling, but the most critical
> tests are basic I/O.
>
Looks like it breaks 3dm2 and the tw_cli. With the patch, I am not able
to see the 8006 controller I added.
tw_cli without the patch
0{offsite2}# tw_cli
//offsite2> /c0 show
Unit UnitType Status %RCmpl %V/I/M Stripe Size(GB) Cache
AVrfy
------------------------------------------------------------------------------
u0 RAID-0 OK - - 64K 931.521 ON
-
Port Status Unit Size Blocks Serial
---------------------------------------------------------------
p0 OK u0 465.76 GB 976773168 WD-WCAYUEY18298
p1 OK u0 465.76 GB 976773168 WD-WMAYUL256317
//offsite2>
//offsite2> show
Ctl Model (V)Ports Drives Units NotOpt RRate VRate BBU
------------------------------------------------------------------------
c0 8006-2LP 2 2 1 0 3 - -
c1 9650SE-2LP 2 2 1 0 1 1 -
The boot array is c1 (the off twa controller)
with the patch (invariants and invariants_support in the kernel)
0{offsite2}# tw_cli
//offsite2> show
Ctl Model (V)Ports Drives Units NotOpt RRate VRate BBU
------------------------------------------------------------------------
c0 9650SE-2LP 2 2 1 0 1 1 -
//offsite2>
---Mike
--
-------------------
Mike Tancsa, tel +1 519 651 3400
Sentex Communications, mike at sentex.net
Providing Internet services since 1994 www.sentex.net
Cambridge, Ontario Canada http://www.tancsa.com/
More information about the freebsd-current
mailing list