SPI rework

Aleksandr Rybalko ray at dlink.ua
Tue Oct 18 09:34:24 UTC 2011


On Tue, 18 Oct 2011 06:17:46 +0800
Adrian Chadd <adrian at freebsd.org> wrote:

>> Hi,
>> 
>> That sounds logical to me. Maybe getting it done before 9.0-RELEASE
>> is a bit rushed?
>> 
>> I can help you test out the flash side of things on my atheros SoC
>> boards.
>> 
>> 
>> Adrian

More thinking give me a better way to fix that.

We leave same structure, but remove KASSERT(cmd->tx_cmd_sz ==
cmd->rx_cmd_sz,""); and fix SPI controllers drivers to care about
possible different sizes.

And of course will fix consumers to set exact what they need.
(dev/flash: cmd_tx_sz=1, data_rx_sz=3 for "device ID" call)

That way better because we will have ability to duplex SPI transfers on
controllers that able to do that, RT305x SPI will return error in case
when sizes specified for both directions.

Comments?

WBW
-- 
Alexandr Rybalko <ray at dlink.ua> 
aka Alex RAY <ray at ddteam.net>


More information about the freebsd-current mailing list