[Call for reviews] Support domain-search option in dhclient(8)

[Jean-Sébastien Pédron]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12.11.2011 21:01, Andrey V. Elsukov wrote:
> I have several questions after a quick view of your patch: 1.
> AFAIR, our dhclient was doing changes in the system configuration
> via dhclient-script, but i don't see that your changes touched it.

Yes, I forgot to include this in the patch. Here's a new version:
http://people.freebsd.org/~dumbbell/dhclient/dhclient-domain-search-b.patch

> 2. Your code handles compressed options. It's good. But it seems
> you don't check names correctness. There were some checks for
> "domain-name" option, probably you can use them.

This is a nice suggestion. I added it in the new version.

> 3. Also it would be good to update man pages :)

Also fixed in the new patch.

Thank you Andrey for your feedback!

- -- 
Jean-Sébastien Pédron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6/9JQACgkQa+xGJsFYOlNbzQCgnlpv8iEPsHlYmJXlBmFrD/CU
0pMAoLYrbwmtbnL9mmU3vIRgaP3bd0N2
=ykon
-----END PGP SIGNATURE-----