if_ath - should it be compiled without ath_hal support?

[Garrett Cooper]

On Wed, Aug 24, 2011 at 10:37 PM, Adrian Chadd <adrian at freebsd.org> wrote:
> Hi,
>
...

> Well, the ath_hal code should be built in as part of the ath module.
> ath needs ath_hal to speak to the MAC/baseband/radio. There's no need
> for #ifdef's to guard them as .. well, they're needed.

Ok.

> I'd like to eventually split out the ath_hal again into a separate
> module and re-instate the separation between HAL and driver code
> (primarily to enforce cleaner code and more stable APIs.)

Good to know. I was just a bit confused with the manpages that say
they're optional after I discovered looking at the driver that they're
hardwired in.

> If you're seeing issues like the above, chances are that you're seeing
> some corruption. Can you please print out the whole value of *rs (ie,
> all the fields of the ath_rx_status struct) so I can see how valid it
> is?

Sure:

(kgdb) p *rs
$1 = {rs_datalen = 244, rs_status = 0 '\0', rs_phyerr = 0 '\0',
rs_rssi = 0 '\0', rs_keyix = 127 '\177', rs_rate = 27 '\033', rs_more
= 0 '\0', rs_tstamp = 2097280, rs_antenna = 8399232, rs_rssi_ctl =
"0\200)", rs_rssi_ext = "\200\000\037", rs_isaggr = 1 '\001',
rs_moreaggr = 1 '\001', rs_num_delims = 0 '\0', rs_flags = 252 'ü',
rs_evm0 = 0, rs_evm1 = 0, rs_evm2 = 0, rs_evm3 = 0, rs_evm4 = 0}

Thanks!
-Garrett