[RFC] adding -Wmissing-include-dirs to CWARNFLAGS

Garrett Cooper yanegomi at gmail.com
Thu Apr 7 20:53:37 UTC 2011


On Thu, Apr 7, 2011 at 1:53 PM, Garrett Cooper <yanegomi at gmail.com> wrote:
> On Thu, Apr 7, 2011 at 11:55 AM, Alexander Best <arundel at freebsd.org> wrote:
>> hi there,
>>
>> i'd like to propose adding -Wmissing-include-dirs to CWARNFLAGS. this will let
>> tinderbox fail, if any new kernel code was committed with (a) broken include
>> dir(s).
>>
>> i ran a test via
>>
>> make toolchains
>> make MAKE_JUST_KERNELS=yes tinderbox
>>
>> and nothing seemed to go wrong with the extra warning enabled. i even found a
>> missing include dir, which should be fixed by the attached patch.
>>
>> opinions?
>>
>> so far i've only tested this with gcc. i think someone on #freebsd-clang told
>> me that -Wmissing-include-dirs is a noop for clang (for whatever reasons).
>
>    make -f /etc/src.conf -VMODULES_OVERRIDE and make -f /etc/src.conf
> -VMODULES_OVERRIDE say... (tinderbox should also really ignore these
> files, but it doesn't currently)?

Sorry. Second invocation should have been make.conf, not src.conf.


More information about the freebsd-current mailing list