HEADS UP: COMPAT_IA32 renamed COMPAT_FREEBSD32

[David O'Brien]

On Thu, Mar 11, 2010 at 07:24:23PM -0700, M. Warner Losh wrote:
> In message: <7d6fde3d1003111720g7dccf93w1f51db88758a5c4d at mail.gmail.com>
>             Garrett Cooper <yanefbsd at gmail.com> writes:
> : On Thu, Mar 11, 2010 at 5:14 PM, Scot Hetzel <swhetzel at gmail.com> wrote:
> : > On Thu, Mar 11, 2010 at 10:36 AM, Mike Jakubik
> : > <mike.jakubik at intertainservices.com> wrote:
> : >> On 3/11/2010 9:50 AM, Nathan Whitehorn wrote:
> : >>> As a result of importing 32-bit compatibility support for non-x86
> : >>> 64-bit platforms, the kernel options COMPAT_IA32 has been renamed
> : >>> COMPAT_FREEBSD32 in revision 205014, so all kernel configurations
> : >>> including this option must be modified accordingly.
> : >>
> : >> That sounds a bit confusing, compatibility with FreeBSD 3.2?
> : >>
> : > I agree that the name COMPAT_FREEBSD32 is confusing, does it mean
> : > compatiblity with FreeBSD 3.2, FreeBSD 32 or 32-bit ARCH's.
> : >
> : > A better name would have been COMPAT_ARCH32 or COMPAT_32BIT_ARCH.
> : 
> : Agreed. Is it possible to change the name again because it really
> : hasn't gotten much traction yet?
> 
> What does the name matter, really?

Yes names matter.  Otherwise we would have made it "DEF8931".  #define
names are chosen to be self-documenting.

  $ grep COMPAT_FREEBSD conf/*
  conf/NOTES:# Note that as a general rule, COMPAT_FREEBSD<n> depends on
  conf/NOTES:# COMPAT_FREEBSD<n+1>, COMPAT_FREEBSD<n+2>, etc.
  conf/NOTES:options      COMPAT_FREEBSD4
  conf/NOTES:options      COMPAT_FREEBSD5
  conf/NOTES:options      COMPAT_FREEBSD6
  conf/NOTES:options      COMPAT_FREEBSD7
  conf/options:COMPAT_FREEBSD4    opt_compat.h
  conf/options:COMPAT_FREEBSD5    opt_compat.h
  conf/options:COMPAT_FREEBSD6    opt_compat.h
  conf/options:COMPAT_FREEBSD7    opt_compat.h

COMPAT_FREEBSD32 is not the same as any of the other well established
"COMPAT_FREEBSD" macros.  So I do see where this could lead to confusion
to users.

-- 
-- David  (obrien at FreeBSD.org)