[RFC] Macro to sum DPCPU vars

John Baldwin jhb at freebsd.org
Thu Jun 10 12:41:44 UTC 2010


On Wednesday 09 June 2010 11:54:53 pm Lawrence Stewart wrote:
> Does anyone have objections to or feedback on the following patch? The 
> macro simplifies the act of calculating an aggregate from DPCPU counters.
> 
> 
http://people.freebsd.org/~lstewart/patches/tcp_ffcaia2008/dpcpu_sum_9.x.r208900.patch
> 
> If anyone is curious how you would use it, take a look at:

I think this is fine, though I'm about to make it smaller.  At Robert's 
request I've come up with some macros to iterate over CPUs to abstract out the 
CPU_ABSENT(), etc. bits.  It is at www.freebsd.org/~jhb/patches/cpu_iter.patch  
Using CPU_FOREACH() should try your macro down slightly.

-- 
John Baldwin


More information about the freebsd-current mailing list