NLS/strerror efficiency
Kostik Belousov
kostikbel at gmail.com
Sun Jan 24 11:37:29 UTC 2010
On Sun, Jan 24, 2010 at 11:58:01AM +0100, Gabor Kovesdan wrote:
> El 2010. 01. 24. 10:19, Peter Jeremy escribi?:
> >I think this is a good start but still needs some work. One issue is
> >that the patch mixes whitespace changes (some not complying with
> >style(9)) and functional changes. This makes it harder to see the
> >functional changes.
> >
> I thought fixing up some style(9) nits was ok but I meant them to be
> compliant with style(9). Could you please point out, which are not
> compliant? Shall I revert the style(9) changes for now?
> >How much of an issue is this in reality? There are two cases to
> >consider:
> >1) A process that dynamically changes its locale.
> >2) Locale files being updated whilst the process is running.
> >
> >The first can be worked around by also caching the current locale
> >and checking that it hasn't changed.
> >
> I'll fix up my patch to do that.
> >The second is more problematic - particularly for long-running
> >programs. Maybe add a timestamp and re-check every minute or 5.
> >
> I agree, that it should track changing catalogs but do we really want
> that? Catalogs are usually bundled with third-party apps and if you
> update something you obviously want to restart that. And in the case of
> strerror(3), catalogs are supposed to be updated with libc and when you
> update libc you probably want to restart everything.
I do not think that this ought to be handled. Dynamic locale change,
on the other hand, is something I have actually seen.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20100124/f0d6ed89/attachment.pgp
More information about the freebsd-current
mailing list