NLS/strerror efficiency

Hajimu UMEMOTO ume at FreeBSD.org
Sat Jan 23 19:18:59 UTC 2010


Hi,

>>>>> On Wed, 20 Jan 2010 10:20:15 +0100
>>>>> Gabor Kovesdan <gabor at FreeBSD.org> said:

gabor> El 2010. 01. 19. 22:20, Kostik Belousov escribió:
> Hi,
> r189765 enabled NLS support for libc. Now, any strerror(3) call causes
> 4 (!) failing stat(2) calls. I think this is untolerable.
>
> Catopen() does not cache the catalog descriptor, at least for libc,
> at least for the case where the open failed.
>    
gabor> Hi Kostik,

gabor> thank you for pointing this out. I'll check the code to see how we could 
gabor> add a caching for the failing catalogs. I'll post the patch here when 
gabor> I'm done.

The gai_strerror(3) has same issue.  How about the attached patch in
this mail?

Sincerely,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: strerror-lock.diff
Type: text/x-patch
Size: 4068 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-current/attachments/20100123/8d18477a/strerror-lock.bin
-------------- next part --------------

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume at mahoroba.org  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/


More information about the freebsd-current mailing list