fixing kobj signatures

John Baldwin jhb at freebsd.org
Fri May 29 14:46:25 UTC 2009


On Friday 29 May 2009 10:15:32 am Andriy Gapon wrote:
> 
> I think I have completed fixing signatures of kobj method implementations in 
the
> whole head tree.
> The current diff here:
> http://people.freebsd.org/~avg/
> 
> It is quite arbitrarily split into the following files:
> kobj-agp.diff
> kobj-arm.diff
> kobj-linker.diff
> kobj-other.diff
> kobj-sound.diff

I haven't looked at kobj-sound, but the rest of these look fine to me.  I 
would drop the 'XXX' comments from return values in miibus_write_reg() 
routines as 'return (0)' in every case seems to be consistent with other NIC 
drivers.

-- 
John Baldwin


More information about the freebsd-current mailing list